Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missed key for some encrypted files #977

Closed
Moskovych opened this issue Dec 21, 2021 · 3 comments · Fixed by #1288
Closed

Missed key for some encrypted files #977

Moskovych opened this issue Dec 21, 2021 · 3 comments · Fixed by #1288

Comments

@Moskovych
Copy link

Moskovych commented Dec 21, 2021

The issue with files (as example) like this:

https://github.com/mozilla/sops/blob/develop/stores/json/test_resources/example.json

File encrypted with GPG, where the FP: E5297818703249D0C60E19E6824612478D1A4CCD, which doesn't exist anywhere.

It is not possible to work on unit tests (for #887) without having that file decrypted.

Discussion: #970

@felixfontein
Copy link
Contributor

@Moskovych I was looking at this today to see whether I could simply generate a new file with known keys, but then I noticed that this file isn't used in the tests at all. So I created a PR (#1288) to simply delete it.

@Moskovych
Copy link
Author

@felixfontein , hmm, now I'm a bit confused, where I should fix tests for my PR 😕

@felixfontein
Copy link
Contributor

@Moskovych that's a very good question, it depends on what exactly is failing. GHA doesn't show the test results from back then anymore, unfortunately. Can you rebase (and also run gofmt -w stores/json/store.go) and force-push?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants