Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support beforeSendTransaction #72

Closed
6 tasks done
marandaneto opened this issue Nov 21, 2022 · 2 comments
Closed
6 tasks done

Support beforeSendTransaction #72

marandaneto opened this issue Nov 21, 2022 · 2 comments

Comments

@marandaneto
Copy link

marandaneto commented Nov 21, 2022 •
edited by kahest
Loading

getsentry/sentry-docs#5814

RN and Capacitor get for free from JS SDK.
Unity gets it for free from .NET SDK.
iOS SDK has to fix this bug.

Tasks
Preview Give feedback
  1. Add beforeSendTransaction sentry-java#2358
    Effort: Small Impact: Small Platform: Android Platform: Java
    adinauer
  2. Support beforeSendTransaction sentry-dart#1151
    Effort: Small Impact: Small Platform: Dart
    denrase
  3. Support BeforeSendTransaction sentry-dotnet#2077
    Effort: Small Feature Impact: Medium Platform: .NET
    SeanFeldman
@marandaneto marandaneto moved this to Needs Discussion in Mobile & Cross Platform SDK Nov 21, 2022
@marandaneto
Copy link
Author

RN and Capacitor get it for free from JS SDK.
RN has to patch the beforeSendTransaction to swallow exceptions and not crash the app in case there are problems similar to other callbacks, I will raise a new issue for that.

@marandaneto marandaneto mentioned this issue Dec 2, 2022
Closed
@mattjohnsonpint mattjohnsonpint mentioned this issue Dec 6, 2022
Closed
@kahest
Copy link
Member

kahest commented Dec 7, 2022 •
edited
Loading

As discussed, iOS tx already go through beforeSend. For IOS we want to wait for the ongoing RFC to decide how to implement this.

@krystofwoldrich krystofwoldrich mentioned this issue Dec 7, 2022
Closed
@mattjohnsonpint mattjohnsonpint mentioned this issue Feb 15, 2023
Closed
7 tasks
@github-project-automation github-project-automation bot moved this from Needs Discussion to Done in Mobile & Cross Platform SDK Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Mobile & Cross Platform SDK
Archived in project
Milestone
No milestone
Development

No branches or pull requests
7 participants
@mattjohnsonpint @kahest @philipphofmann @romtsn @marandaneto @bitsandfoxes @brustolin