From fb65172412f17f2be3fd5fbf0e365cf1df8b8e33 Mon Sep 17 00:00:00 2001 From: Sebastian Zivota Date: Tue, 17 Jan 2023 12:11:36 +0100 Subject: [PATCH] Clippy --- crates/symbolicator-service/tests/integration/e2e.rs | 1 + .../tests/integration/source_errors.rs | 8 ++------ 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/crates/symbolicator-service/tests/integration/e2e.rs b/crates/symbolicator-service/tests/integration/e2e.rs index 97b40b4f3..8688cd02e 100644 --- a/crates/symbolicator-service/tests/integration/e2e.rs +++ b/crates/symbolicator-service/tests/integration/e2e.rs @@ -495,6 +495,7 @@ fn get_files(path: impl AsRef) -> Vec<(String, u64)> { } /// Tests caching side-effects, like cache files written and hits to the symbol source. +#[allow(clippy::if_same_then_else)] #[tokio::test] async fn test_basic_windows() { let (modules, stacktraces) = request_fixture(); diff --git a/crates/symbolicator-service/tests/integration/source_errors.rs b/crates/symbolicator-service/tests/integration/source_errors.rs index fbab465f5..eb984c974 100644 --- a/crates/symbolicator-service/tests/integration/source_errors.rs +++ b/crates/symbolicator-service/tests/integration/source_errors.rs @@ -37,7 +37,7 @@ async fn test_download_errors() { }; // NOTE: we run requests twice to make sure that round-trips through the cache give us the same results. - for i in 0..2 { + for _i in 0..2 { // NOTE: we try this 3 times on error let source = hitcounter.source("rejected", "/respond_statuscode/500/"); let request = get_symbolication_request(vec![source]); @@ -100,11 +100,7 @@ async fn test_download_errors() { // FIXME: We are currently serializing `CacheError` in "legacy" mode that does // not support details // FIXME: However, adding an in-memory cache means we still get the proper values - details: if i == 0 { - "403 Forbidden".into() - } else { - "403 Forbidden".into() - } + details: "403 Forbidden".into() } ) );