fix(dashboards): Abbreviate LineChartWidget Y axis integers
#81937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
nikkikapadia
approved these changes
Dec 10, 2024
static/app/views/dashboards/widgets/lineChartWidget/formatYAxisValue.tsx
Outdated
Show resolved
Hide resolved
gggritso
deleted the
fix/dashboards/abbreviate-line-chart-big-numbers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts numbers like "800,000" to "800k" in the Y Axis of
LineChartWidgetbut not in the tooltip! I split theformatChartValuefunction into two, one for formatting the value in the Y axis, and one for formatting the value for the tooltip. They're different! In the tooltip we expect to have more digits.I'll continue to tweak this as I find more cases.