ref: fix flaky digests test #81256
Merged
ref: fix flaky digests test #81256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuarli
approved these changes
Nov 25, 2024
andrewshie-sentry
pushed a commit
that referenced
this pull request
Dec 2, 2024
relay [rounds timestamps](https://github.com/getsentry/relay/blob/0459abec0ee79f773d163f35e742cebd34134793/relay-event-schema/src/protocol/types.rs#L896) whereas the test truncates I first forced the test to fail with: ```diff diff --git a/tests/sentry/notifications/notifications/test_digests.py b/tests/sentry/notifications/notifications/test_digests.py index be02406aa1..2943b1875e 100644 --- a/tests/sentry/notifications/notifications/test_digests.py +++ b/tests/sentry/notifications/notifications/test_digests.py @@ -163,7 +163,10 @@ class DigestSlackNotification(SlackActivityNotificationTest): backend = RedisBackend() digests.backend.digest = backend.digest digests.enabled.return_value = True - timestamp_raw = before_now(days=1) + while True: + timestamp_raw = before_now(days=1) + if int(timestamp_raw.timestamp()) != round(timestamp_raw.timestamp()): + break timestamp_secs = int(timestamp_raw.timestamp()) timestamp = timestamp_raw.isoformat() key = f"slack:p:{self.project.id}:IssueOwners::AllMembers" ``` <!-- Describe your PR here. -->
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relay rounds timestamps whereas the test truncates
I first forced the test to fail with: