feat(explore): Linking to spans in traceview from all tables #78984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Bundle ReportChanges will increase total bundle size by 7.55kB (0.02%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
❌ 2 Tests Failed:
View the top 2 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
JonasBa
reviewed
Oct 11, 2024
JonasBa
reviewed
Oct 11, 2024
Zylphrex
reviewed
Oct 11, 2024
Zylphrex
approved these changes
Oct 11, 2024
cmanallen
pushed a commit
that referenced
this pull request
Oct 23, 2024
There's no concept of `transaction.id` in eap. We now have access to `transaction.span_id` in both EAP and Indexed datasets. This PR enables sending `transaction.span_id` as `targetId` to the `events_trace` endpoint to ensure the transaction is always included in the response. Not the most proud of this solution, will follow up with PRs to completely replace `eventId`=`transaction.id` with `targetId`=`transaction.span_id`. PR also enables finding transactions by their span_ids in the trace view. With this change we can successfully scroll to spans and txns in the traceview from all explore tables using only span_ids. --------- Co-authored-by: Abdullah Khan <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no concept of
transaction.idin eap. We now have access totransaction.span_idin both EAP and Indexed datasets.This PR enables sending
transaction.span_idastargetIdto theevents_traceendpoint to ensure the transaction is always included in the response. Not the most proud of this solution, will follow up with PRs to completely replaceeventId=transaction.idwithtargetId=transaction.span_id.PR also enables finding transactions by their span_ids in the trace view. With this change we can successfully scroll to spans and txns in the traceview from all explore tables using only span_ids.