-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(proguard): Deobfuscate view hierarchies as part of symbolication #74196
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes in this file look much worse than they are. Basically we need to make the test compatible with Symbolicator, so it needs with set_sentry_option("system.url-prefix", live_server.url):
at the beginning.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #74196 +/- ##
========================================
Coverage 78.14% 78.15%
========================================
Files 6650 6650
Lines 297301 297042 -259
Branches 51186 51112 -74
========================================
- Hits 232326 232153 -173
+ Misses 58708 58659 -49
+ Partials 6267 6230 -37
|
Depends on getsentry/symbolicator#1496.
This moves view hierarchy deobfuscation out of the plugin/preprocessor and into symbolication. That allows us to remove proguard processing from Sentry entirely and only have it in Symbolicator.
Since this means we would potentially want to send JVM events to Symbolicator that don't have exceptions or stacktraces, we have to be more lenient when detecting such events (see the change to
is_jvm_event
). I don't think this presents a problem—we still check if the event contains anything that needs to be symbolicated before we actually send it.The bigger problem is that merely modifying theThis was due to some trivial mistake or other that got fixed along the way.attachment_cache
the way I'm doing right now doesn't appear to be enough to actually save the modified attachment. The current code where that happens in the preprocessor does just that, but I assume there is some point where the cache is persisted that we don't hit if we do this in symbolication. I need to understand this better.