Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe Do not add sentry-trace header by default? #4184

Closed
silentMood opened this issue Nov 25, 2021 · 2 comments
Closed

Maybe Do not add sentry-trace header by default? #4184

silentMood opened this issue Nov 25, 2021 · 2 comments

Comments

@silentMood
Copy link

Well, that's my fault, I didn't read all the doc before i add sentry into our project.
Here's what happen, I added sentry into our project. without the tracingOrigins settings, just follow the guide page.
So the sentry add all the outgoing cdn request with header sentry-trace. This make our all cdn request become not simple.
All our cdn request need to send a preflight requst before send the real request, And Our CDN just not do the setting to support OPTIONS method.
So that's how the diaster happen.
So I think maybe do less global change by default. maybe will be better. or add this notice in the guide page.

@AbhiPrasad
Copy link
Member

This is worthwhile investigating to see how we can make it more clear, but at the current moment there are no plans to make changes here.

PRs and contributions to address this in our documentation are welcome! https://github.com/getsentry/sentry-docs

@silentMood
Copy link
Author

@AbhiPrasad thanks for reply, okay, I can do some help for the doc at this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants