-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Clear activeTransaction from the scope and always start idle timers #3215
Conversation
size-limit report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a it("finishes unsampled transactions")
test and a it("removes unsampled transactions from the scope when finished")
test, since those are what this PR aims to fix?
Otherwise LGTM. 🙂
d52947b
to
aa7b3c9
Compare
I think it's covered by
Added. |
aa7b3c9
to
be2cce9
Compare
This makes sure, that after sampling a transaction, all future transactions are still captured correctly.