Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Clear activeTransaction from the scope and always start idle timers #3215

Merged
merged 3 commits into from
Feb 1, 2021

Conversation

kamilogorek
Copy link
Contributor

This makes sure, that after sampling a transaction, all future transactions are still captured correctly.

@kamilogorek kamilogorek requested a review from a team January 28, 2021 15:48
@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2021

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 20.33 KB (-0.01% 🔽)
@sentry/browser - Webpack 21.21 KB (0%)
@sentry/react - Webpack 21.23 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 27.26 KB (+0.01% 🔺)

Copy link
Member

@lobsterkatie lobsterkatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a it("finishes unsampled transactions") test and a it("removes unsampled transactions from the scope when finished") test, since those are what this PR aims to fix?

Otherwise LGTM. 🙂

@kamilogorek kamilogorek force-pushed the clear-active-transaction branch from d52947b to aa7b3c9 Compare February 1, 2021 13:34
@kamilogorek
Copy link
Contributor Author

Can we add a it("finishes unsampled transactions") test

I think it's covered by finishes a transaction after 3 beats test.

and a it("removes unsampled transactions from the scope when finished") test

Added.

@kamilogorek kamilogorek force-pushed the clear-active-transaction branch from aa7b3c9 to be2cce9 Compare February 1, 2021 13:40
This was referenced Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants