-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose ignoreComponents
as an Option
#622
Labels
Comments
@0Calories do we wanna expose this option? Can we find a simpler interface than |
Hello Sentry team! I was wondering if you have any updates on this issue? Thank you in advance. 🙂 |
Hey @angel3cu, this feature is currently in our backlog – I'll bring it up again this week as I think this generally makes sense. |
cc @0Calories |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@sentry/babel-plugin-component-annotate
seems to have an undocumented option to ignore specific files and/or components. This is coming from the original plugin that is is based on. The option is calledignoreComponents
and can be seen documented in the original FullStory plugin here.In some cases, adding properties to a component at build time interacts with other libraries, causing them to fail. One such scenario is Mapbox, where Sentry adds
data-sentry-component
anddata-sentry-source-file
into the properties of theSource
component. Mapbox validates all the properties of its React components; when it encounters the properties injected by Sentry, it fails. Even worse, since in most scenarios Sentry is only used in production, this failure won't be visible until it is too late.The root cause of the failure here is the
reactComponentAnnotation
feature. It currently has a simpleenabled
option to turn it on and off. Given how useful the feature is for debugging issues, we would like to keep it on and only exclude the components that fail. If we could expose the underlyingignoreComponents
in the Vite plugin, then that goal would be achieved.e.g.
The text was updated successfully, but these errors were encountered: