Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DECISION] Add RFC for top level span creation method #28

Closed
AbhiPrasad opened this issue Oct 18, 2022 · 2 comments · Fixed by #101
Closed

[DECISION] Add RFC for top level span creation method #28

AbhiPrasad opened this issue Oct 18, 2022 · 2 comments · Fixed by #101
Assignees
@cleptric @AbhiPrasad

Comments

@AbhiPrasad
Copy link
Member

ref:

Introduce a Sentry.trace method that wraps a callback with a created span.
@AbhiPrasad AbhiPrasad moved this from Backlog to Todo in Sentry <3s OpenTelemetry Oct 18, 2022
@sl0thentr0py
Copy link
Member

in ruby we just added
getsentry/sentry-ruby#1783
we can rename in a major for consistency if this becomes unified API

@AbhiPrasad AbhiPrasad changed the title Add RFC for top level span creation method [otel] Add RFC for top level span creation method Oct 18, 2022
@AbhiPrasad AbhiPrasad changed the title [otel] Add RFC for top level span creation method [DECISION] Add RFC for top level span creation method Oct 18, 2022
@AbhiPrasad AbhiPrasad mentioned this issue Oct 18, 2022
Closed
@AbhiPrasad
Copy link
Member Author

Wrote out why this is need for OpenTelemetry here: getsentry/develop#720

@AbhiPrasad AbhiPrasad moved this from Todo to In Progress in Sentry <3s OpenTelemetry Oct 19, 2022
@AbhiPrasad AbhiPrasad moved this from In Progress to Todo in Sentry <3s OpenTelemetry Oct 19, 2022
@AbhiPrasad AbhiPrasad moved this from Todo to In Progress in Sentry <3s OpenTelemetry Oct 20, 2022
@AbhiPrasad AbhiPrasad moved this from In Progress to Todo in Sentry <3s OpenTelemetry Oct 28, 2022
@AbhiPrasad AbhiPrasad moved this from Todo to Backlog in Sentry <3s OpenTelemetry Nov 21, 2022
@AbhiPrasad AbhiPrasad mentioned this issue Jun 15, 2023
Merged
@AbhiPrasad AbhiPrasad moved this to In Review in Sentry <3s OpenTelemetry Jun 15, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Sentry <3s OpenTelemetry Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cleptric cleptric

@AbhiPrasad AbhiPrasad

Labels
None yet
Projects
Sentry <3s OpenTelemetry
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rfc(decision): Revamping the SDK Performance API getsentry/rfcs
3 participants
@sl0thentr0py @cleptric @AbhiPrasad