Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve dependency using bundle interface #2686

Open
1 task
Tracked by #2678
carolynvs opened this issue Mar 31, 2023 · 0 comments
Open
1 task
Tracked by #2678

Resolve dependency using bundle interface #2686

carolynvs opened this issue Mar 31, 2023 · 0 comments
Labels
pep003-advanced-dependencies Implementation of the Advanced Dependencies proposal placeholder Tracks work that has not yet be fully designed

Comments

@carolynvs
Copy link
Member

carolynvs commented Mar 31, 2023

Given a bundle interface, it is used differently based on the situation:

  • Are we checking the default bundle implementation or one of its versions? Then the credentials and parameters must match because the parameter and credential mappings defined on a dependency must be used with the default bundle.
  • Are we checking an arbitrary bundle, such as a provider's implementation of a well-known interface or a user-supplied bundle? Then we just care about outputs, and if a mapping is defined that we can't use, it's ignored (though we may still warn about it).
  • Are we checking an existing installation? In this case parameters and creds don't matter, it's already installed, so we just care about the outputs it supplies.

So when we are determining if a node in the dependency graph can be satisfied, it must be updated to properly take the bundle interface into account. See the following from the proposal for more details

Question

  • Let's review and validate the assumption that creds/params don't matter for installations because it's "already installed". That makes sense for install, but for upgrade, custom actions, uninstall those params/creds may be relevant again. 🤔

Dependencies

ℹ️ Read PEP003 - Advanced Dependencies for context about how dependencies should work, design details, and notes about desired behavior.

@carolynvs carolynvs added pep003-advanced-dependencies Implementation of the Advanced Dependencies proposal placeholder Tracks work that has not yet be fully designed labels Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pep003-advanced-dependencies Implementation of the Advanced Dependencies proposal placeholder Tracks work that has not yet be fully designed
Projects
No open projects
Status: No status
Development

No branches or pull requests

1 participant