Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve dependency digests during build #2676

Closed
Tracked by #2667 ...
carolynvs opened this issue Mar 30, 2023 · 0 comments · Fixed by #3071
Closed
Tracked by #2667 ...

Resolve dependency digests during build #2676

carolynvs opened this issue Mar 30, 2023 · 0 comments · Fixed by #3071
Assignees
Labels
hmm 🛑🤔 Needs more thinking time. Don't start on it yet, please. pep003-advanced-dependencies Implementation of the Advanced Dependencies proposal placeholder Tracks work that has not yet be fully designed

Comments

@carolynvs
Copy link
Member

carolynvs commented Mar 30, 2023

During porter build, we should resolve the repository digest for each dependency that has a default bundle reference specified. The reference in the final porter.yaml stored in ./cnab/app/porter.yaml should use the digest instead of the tag.

Questions

[ ] It is still TBD how we will preserve the original tag in the bundle to use later for relocation mapping (#2670)

ℹ️ Read PEP003 - Advanced Dependencies for context about how dependencies should work, design details, and notes about desired behavior.

@carolynvs carolynvs added pep003-advanced-dependencies Implementation of the Advanced Dependencies proposal placeholder Tracks work that has not yet be fully designed labels Mar 30, 2023
@carolynvs carolynvs added the hmm 🛑🤔 Needs more thinking time. Don't start on it yet, please. label Mar 30, 2023
@schristoff schristoff moved this to Todo in v1.1.0 (June 2024) Apr 4, 2024
@kichristensen kichristensen self-assigned this May 2, 2024
@kichristensen kichristensen moved this from Todo to In Progress in v1.1.0 (June 2024) May 6, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in v1.1.0 (June 2024) May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hmm 🛑🤔 Needs more thinking time. Don't start on it yet, please. pep003-advanced-dependencies Implementation of the Advanced Dependencies proposal placeholder Tracks work that has not yet be fully designed
Projects
Status: Done
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants