Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete definition of .PHONY in Makefile generated by quickstart #3065

Closed
2 tasks done
nohamelin opened this issue Nov 20, 2022 · 1 comment
Closed
2 tasks done
Labels

Comments

@nohamelin
Copy link

nohamelin commented Nov 20, 2022

  • I have read the Filing Issues and subsequent “How to Get Help” sections of the documentation.
  • I have searched the issues (including closed ones) and believe that this is not a duplicate.
  • Pelican version: master branch at the time opening this issue (commit f015ab8).

Issue

Hi,
The always-available devserver-global command is not listed as a phony target in the Makefile generated by the quickstart.

Also, only by taking a fast look to that Makefile template, it seems that sftp_upload is missing too (it's not added to the upload list).

Regards.

@nohamelin nohamelin added the bug label Nov 20, 2022
@nohamelin
Copy link
Author

Note that multiple .PHONY definitions are cumulative, so you could to have something as the following:

.PHONY: html
html:
	"$(PELICAN)" "$(INPUTDIR)" -o "$(OUTPUTDIR)" -s "$(CONFFILE)" $(PELICANOPTS)

.PHONY: clean
clean:
	[ ! -d "$(OUTPUTDIR)" ] || rm -rf "$(OUTPUTDIR)"

.PHONY: regenerate
regenerate:
	"$(PELICAN)" -r "$(INPUTDIR)" -o "$(OUTPUTDIR)" -s "$(CONFFILE)" $(PELICANOPTS)

It could make it less likely to forget adding a target to .PHONY in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant