Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testsuite: Build_doctests missing from exposed-modules or other-modules #268

Open
juhp opened this issue Jul 3, 2021 · 2 comments
Open

Comments

@juhp
Copy link
Collaborator

juhp commented Jul 3, 2021

This is not very serious and I don't use hpack much, so maybe it can't handle it but this warning is appearing when linking the testsuite:

Warning: The following modules should be added to exposed-modules or other-modules in /var/home/petersen/github/hawk/haskell-awk.cabal:
             - In test:reference:
                 Build_doctests
             - In test:reference:
                 Build_doctests
             - In test:reference:
                 Build_doctests
         
         Missing modules in the cabal file are likely to cause undefined reference errors from the linker, along with other problems.

I couldn't persuade hpack to add it, so maybe it is wontfix, unless we want to drop using hpack at some point?

@gelisam
Copy link
Owner

gelisam commented Jul 4, 2021

unless we want to drop using hpack at some point?

now that cabal supports common stanzas, the only remaining hpack feature I care about is automatically grabbing all the .hs files from a folder, so I don't have to edit the .cabal file every time I create a new package. My ex-colleague made a build-time library which is supposed to bring this functionality to cabal, should we try it?

@juhp
Copy link
Collaborator Author

juhp commented Jul 5, 2021

Ya, we can give it a go, if you want.
I would be in favour of moving away from hpack anyway: I feel hint seems too complicated for it, though it is doing pretty well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants