Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable the tests #174

Closed
gelisam opened this issue Mar 8, 2018 · 2 comments
Closed

Re-enable the tests #174

gelisam opened this issue Mar 8, 2018 · 2 comments

Comments

@gelisam
Copy link
Owner

gelisam commented Mar 8, 2018

In #173, I disabled the tests. This was meant to be a temporary solution: let's enable them again.

Last time I worked on hawk (#155), I got stuck because the tests were green on my machine but not on Travis. Years layer, the situation has worsened: the tests seem to have bit-rotted, and the tests don't pass on my machine either anymore. There were too many failures so simply fix them all, and I am expecting some contributions soon, so I don't want the failing tests to be an obstacle to those contributions. So I have disabled the tests for now.

Since there are so many failures, my plan to make re-enabling the tests more manageable is to split the work into several smaller issues. The scope of this issue is:

  • figure out which modules have failing tests
  • for each failing module, open an issue to re-enable its tests
  • re-enable the modules which don't have failing tests
@gelisam
Copy link
Owner Author

gelisam commented Nov 26, 2018

I found three doctests fail in System.Console.Hawk.Args.Parse (#198), ten doctests fail in Control.Monad.Trans.OptionParser (#199), twelve doctests fails in System.Console.Hawk.PreludeTests (#200), and one failing test in System.Console.Hawk.Test (#201).

@gelisam
Copy link
Owner Author

gelisam commented Nov 27, 2018

The tests pass with stack test and cabal test (after cabal sandbox init and cabal install --enable-tests), but not with cabal new-test. With #186 still unresolved, I guess that shouldn't be surprising!

@gelisam gelisam mentioned this issue Nov 27, 2018
@gelisam gelisam closed this as completed Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant