Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid circular navigation for Activities accessible via nav drawer #685

Open
esoxjem opened this issue Oct 6, 2016 · 3 comments
Open

Avoid circular navigation for Activities accessible via nav drawer #685

esoxjem opened this issue Oct 6, 2016 · 3 comments
Labels

Comments

@esoxjem
Copy link
Collaborator

esoxjem commented Oct 6, 2016

This is to avoid circular navigation adding to stack: Home > GDE > Pulse > GDE > Home

@tasomaniac
Copy link
Member

That's a really good problem that we have for a long time. Thanks for bringing that up.

I don't know if having singleTask is the best solution to that. We can also use Intent flags to do this. I guess we don't have to set it Manifest level.

@tasomaniac tasomaniac changed the title Activities accessible via nav drawer should be singleTask Avoid circular navigation for Activities accessible via nav drawer Oct 7, 2016
@tasomaniac tasomaniac added the bug label Oct 7, 2016
@esoxjem
Copy link
Collaborator Author

esoxjem commented Oct 13, 2016

@tasomaniac I think flags should be used to override the default behaviour defined in the manifest. Also, if you look at gmail's behaviour, pressing back from any of the activities brings you home. Maybe we shouldn't add them to the backstack?

@tasomaniac
Copy link
Member

tasomaniac commented Oct 13, 2016

Exactly, flags should be override the default behavior. And default behavior should not be singleTask in our case. These Activity's can potentially be launched by other screens like widgets notification etc. In those cases, new task should be created. Putting singleTask in Manifest makes it impossible.

But I agree with you about the behavior. It's bad. We should be more intelligent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants