You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We're ready to default to Fortress for Rolling. Since bloom doesn't allow the injection of custom environment variables (see ros-infrastructure/bloom#517), the release will always take the default conditionals on package.xml and CMakeLists.txt. This means we need to branch off just so each branch defaults to a different version:
galactic defaults to Edifice
ros2 (rolling, future humble) defaults to Fortress
Desired behavior
The galactic branch can be released using Edifice and the ros2 branch can be released using Fortress.
Alternatives considered
I can't think of anything besides bloom allowing the injection of environment variables, or another way of passing parameters.
Implementation suggestion
Create the galactic branch off ros2 and enable branch protection
Open PRs for all versions updating the README with the new branch
We're ready to default to Fortress for Rolling. Since bloom doesn't allow the injection of custom environment variables (see ros-infrastructure/bloom#517), the release will always take the default conditionals on
package.xml
andCMakeLists.txt
. This means we need to branch off just so each branch defaults to a different version:galactic
defaults to Edificeros2
(rolling, future humble) defaults to FortressDesired behavior
The
galactic
branch can be released using Edifice and theros2
branch can be released using Fortress.Alternatives considered
I can't think of anything besides bloom allowing the injection of environment variables, or another way of passing parameters.
Implementation suggestion
galactic
branch offros2
and enable branch protectionmelodic
: [melodic] Update docs for ros2 branches #202melodic
tonoetic
galactic
: also remove Rolling support: Separate galactic branch from ros2 branch #201foxy
: [foxy] Update docs for ros2 branches #203ros
Update Default to Fortress for Rolling (future Humble) #195 so theros2
branch is only for Rollinggalactic
and update therosdistro
branch togalactic
ros2
for Rolling using FortressAdditional context
Previous tickets which provide more context:
The text was updated successfully, but these errors were encountered: