Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix thruster integration test #1767

Merged
merged 1 commit into from
Oct 21, 2022
Merged

Fix thruster integration test #1767

merged 1 commit into from
Oct 21, 2022

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Oct 20, 2022

Signed-off-by: Nate Koenig [email protected]

🦟 Bug fix

Summary

PR #1754 applied the wrong logic here. This fixes the problem.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Fix thruster integration test
f39ae46 
Signed-off-by: Nate Koenig <[email protected]>
@nkoenig nkoenig requested a review from mjcarroll as a code owner October 20, 2022 23:07
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Oct 20, 2022
@nkoenig nkoenig merged commit 77ea80c into ign-gazebo6 Oct 21, 2022
@nkoenig nkoenig deleted the nkoenig/fix_thruster_test branch October 21, 2022 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

Assignees
No one assigned
Labels
🏯 fortress Ignition Fortress
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nkoenig @mjcarroll