Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OdometryPublisher xyz_global_offset, rpy_global_offset #2515

Open
aserbremen opened this issue Aug 5, 2024 · 3 comments
Open

OdometryPublisher xyz_global_offset, rpy_global_offset #2515

aserbremen opened this issue Aug 5, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request help wanted We accept pull requests!

Comments

@aserbremen
Copy link

Desired behavior

Being able to configure the global intial/odometry frame position with the OdometryPublisher using something like xyz_global_offset, rpy_global_offset . This way it would be possible to publish the ground truth odometry of an entity wrt. to an arbitrary frame (e.g. using odom_frame=odom and robot_base_frame=base_link).

Alternatives considered

I tried to use xyz_offset and rpy_offset but the odometry result is changed in body-fixed coordinates, so that these parameters cannot be used to achieve the desired behavior. When rotating the entity that uses xyz_offset and rpy_offset the pose is changed drastically and is not usable anymore.

Implementation suggestion

This file has to be changed, with the additional parameter: https://github.com/gazebosim/gz-sim/blob/gz-sim8/src/systems/odometry_publisher/OdometryPublisher.cc

Additional context

I use Gazebo Sim, version 6.16.0.

@aserbremen aserbremen added the enhancement New feature or request label Aug 5, 2024
@azeey
Copy link
Contributor

azeey commented Aug 6, 2024

Thanks for the feature request. It would a nice capability to have. Are you interested in working on it?

@azeey azeey added the help wanted We accept pull requests! label Aug 6, 2024
@azeey azeey removed this from Core development Aug 6, 2024
@aserbremen
Copy link
Author

Sure, I can give it a try. What would be the workflow if I have gazebo installed from debian packages on my local machine.

Do I clone my forked gz-sim into a colcon workspace and build it locally. Then i have to make sure to launch the world using the local ign binary gazebo, I suppose?

Due to work-related deadlines, I might be only to work on it at the end of October, but I will keep you updated.

@azeey
Copy link
Contributor

azeey commented Aug 7, 2024

It would be best to open a PR on the latest stable version (gz-sim8 or gz-sim9 by October) and then backport to the version you're using.

Do I clone my forked gz-sim into a colcon workspace and build it locally. Then i have to make sure to launch the world using the local ign binary gazebo, I suppose?

Mixing system installed versions with source builds can be tricky so I recommend building the whole collection from source following this tutorial.

Due to work-related deadlines, I might be only to work on it at the end of October, but I will keep you updated.

That's actually good because we are in feature freeze right now and would not be able to review a PR until October anyway.

@azeey azeey moved this from Inbox to In progress in Core development Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted We accept pull requests!
Projects
Status: In progress
Development

No branches or pull requests

2 participants