Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup GUI plugin menu #1254

Closed
chapulina opened this issue Dec 15, 2021 · 2 comments
Closed

Cleanup GUI plugin menu #1254

chapulina opened this issue Dec 15, 2021 · 2 comments
Assignees
Labels
bug Something isn't working GUI Gazebo's graphical interface (not pure Ignition GUI) OOBE 📦✨ Out-of-box experience

Comments

@chapulina
Copy link
Contributor

Environment

  • OS Version: all
  • Source or binary build? all

Description

  • Expected behavior:

    Inserting a plugin from the top-right menu should never crash. When inserting a plugin that doesn't have any widgets, we should add some text explaining to the user that this is the case, otherwise the user may think they're doing something wrong, or something is broken.

  • Actual behavior:

    Inserting plugins like Scene3D crash the application... Plugins like KeyPublisher are empty.

Steps to reproduce

Insert various plugins from the menu and see how some behave badly.

@chapulina chapulina added bug Something isn't working GUI Gazebo's graphical interface (not pure Ignition GUI) labels Dec 15, 2021
@chapulina chapulina added the OOBE 📦✨ Out-of-box experience label Dec 20, 2021
@chapulina
Copy link
Contributor Author

chapulina commented Jan 7, 2022

Progress tracking

Citadel

Plugin Status
Component Inspector ok ✔️
Scene 3D crash 💥 gazebosim/gz-gui#347 ✔️
Teleop ok ✔️
Entity tree ok ✔️
Video Recorder ok ✔️
Grid 3D Empty gazebosim/gz-gui#363 ✔️
Shapes ok ✔️
Grid config ok ✔️
Topic Viewer ok ✔️
Gz Scene 3D Empty, eventual crash 💥 #1294 ✔️
World control Empty gazebosim/gz-gui#349 ✔️
Image display ok ✔️
Screenshot ok ✔️
Joint position controller ok ✔️
Tape measure ok ✔️
Key publisher Empty gazebosim/gz-gui#362 ✔️
Topic echo ok ✔️
Playback scrubber ok ✔️
Transform control ok ✔️
Plot 3D ok, but lots of warnings are printed ✔️
View angle ok ✔️
Publisher ok ✔️
World stats Empty gazebosim/gz-gui#349 ✔️
Resource spawner ok ✔️
Align tool ok ✔️
Shutdown button ok ✔️

Fortress

Only plugins that aren't on Citadel

Plugin Status
Banana for scale ok ✔️
Camera tracking Empty gazebosim/gz-gui#366 ✔️
Visualize contacts ok ✔️
Transport scene manager Freeze 🧊 gazebosim/gz-gui#365 ✔️
Copy paste ok ✔️
Entity context menu Empty #1375 ✔️
Select entities Empty #1375 ✔️
Gz Scene manager Crash 💥 #1371 ✔️
Interactive view controller Empty gazebosim/gz-gui#366 ✔️
Joint position controller ok ✔️
Spawn Empty #1375 ✔️
Lights ok ✔️
Marker manager Empty gazebosim/gz-gui#366 ✔️
Transport plotting ok ✔️
Minimal scene Freeze / crash 💥 gazebosim/gz-gui#364 ✔️
Nav Sat Map ok ✔️
Visualization capabilities Empty #1375 ✔️
Visualize lidar ok ✔️
Plotting ok ✔️

@chapulina
Copy link
Contributor Author

All PRs merged. No plugins should crash / freeze or be empty on insertion now. We should be careful not to add new plugins that break these rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working GUI Gazebo's graphical interface (not pure Ignition GUI) OOBE 📦✨ Out-of-box experience
Projects
None yet
Development

No branches or pull requests

1 participant