fix(gatsby-source-contentful): De-dupe type names #30834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
ascorbic
changed the title
vladar
added
topic: GraphQL
vladar
added
the
topic: source-contentful
vladar
pushed a commit
that referenced
this pull request
Apr 13, 2021
* fix(gatsby-source-contentful): De-dupe layout type name * Add placeholder type too (cherry picked from commit 71ec0cd)
vladar
pushed a commit
that referenced
this pull request
Apr 13, 2021
* fix(gatsby-source-contentful): De-dupe layout type name * Add placeholder type too (cherry picked from commit 71ec0cd) Co-authored-by: Matt Kane <[email protected]>
This was referenced Apr 13, 2021
This was referenced Nov 28, 2023
This was referenced Nov 29, 2023
This was referenced Nov 29, 2023
This was referenced Nov 29, 2023
This was referenced Nov 29, 2023
This was referenced Nov 29, 2023
This was referenced Nov 29, 2023
This was referenced Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because this plugin uses
setFieldsOnGraphQLNodeTyperather thancreateSchemaCustomization, type names are not merged and deduped. This leads to bugs like this. This PR is a quick fix that renames the offending types. The proper fix though is to switch to the newer API that handles types properly.