Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gatsby-plugin-catch-links] doesn't seem to work #4318

Closed
daaain opened this issue Mar 1, 2018 · 2 comments · Fixed by #4329
Closed

[gatsby-plugin-catch-links] doesn't seem to work #4318

daaain opened this issue Mar 1, 2018 · 2 comments · Fixed by #4329
Assignees

Comments

@daaain
Copy link

daaain commented Mar 1, 2018

Description

I thought it's my website being special, but it seems there's an issue with gatsby-plugin-catch-links (or its dependencies).

Actual result

Page reloads.

Expected behavior

pushState page change.

Steps to reproduce

1. Go to https://using-remark.gatsbyjs.org/excerpts/

2. Click on the last link on the page ("You can see the results here").

3. Page reloads :(

@m-allanson
Copy link
Contributor

@daaain Thanks for the report and providing a good example. You're right that this plugin isn't working as expected, I've added a PR that should fix it.

@ghost ghost removed the review label Mar 2, 2018
@daaain
Copy link
Author

daaain commented Mar 2, 2018

Thanks a lot, just updated the packages and it fixed the issue on my website too 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants