Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetMachineStatus prevents machine deletion in case of Unitialised error code #926

Closed
rishabh-11 opened this issue Jul 10, 2024 · 0 comments · Fixed by #928
Closed

GetMachineStatus prevents machine deletion in case of Unitialised error code #926

rishabh-11 opened this issue Jul 10, 2024 · 0 comments · Fixed by #928
Assignees
Labels
area/performance Performance (across all domains, such as control plane, networking, storage, etc.) related area/robustness Robustness, reliability, resilience related kind/bug Bug priority/1 Priority (lower number equals higher priority) status/closed Issue is closed (either delivered or triaged)

Comments

@rishabh-11
Copy link
Contributor

How to categorize this issue?

/area performance
/area robustness
/kind bug
/priority 1

What happened:
With #898, we introduced InitializeMachine in the driver API. There is an edge case here where an initialized machine can cause its deletion to be stuck (See landscape-issues 147). This happens because of the triggerDeletionFlow calls GetMachineStatus in getVMStatus stage. (See

func (c *controller) getVMStatus(ctx context.Context, getMachineStatusRequest *driver.GetMachineStatusRequest) (machineutils.RetryPeriod, error) {
). The error handling of Unitialized error code is not done here causing the deletion to get stuck.

What you expected to happen:
The deletion of an initialized machine should not get stuck.

Anything else we need to know?:

@rishabh-11 rishabh-11 added the kind/bug Bug label Jul 10, 2024
@gardener-robot gardener-robot added area/performance Performance (across all domains, such as control plane, networking, storage, etc.) related area/robustness Robustness, reliability, resilience related priority/1 Priority (lower number equals higher priority) labels Jul 10, 2024
@rishabh-11 rishabh-11 self-assigned this Jul 10, 2024
@elankath elankath self-assigned this Jul 11, 2024
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/performance Performance (across all domains, such as control plane, networking, storage, etc.) related area/robustness Robustness, reliability, resilience related kind/bug Bug priority/1 Priority (lower number equals higher priority) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants