Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The current implementation using WeakMap is resulting in memory leaks #36

Closed
gajus opened this issue Feb 21, 2019 · 2 comments
Closed

The current implementation using WeakMap is resulting in memory leaks #36

gajus opened this issue Feb 21, 2019 · 2 comments
Assignees
@gajus
Labels
needs-replication

Comments

@gajus
Copy link
Owner

gajus commented Feb 21, 2019

Redevelop the guard using Symbol.
@gajus gajus self-assigned this Feb 21, 2019
@gajus
Copy link
Owner Author

gajus commented Feb 21, 2019

Flow does not support using Symbol to distinguish object shape.

facebook/flow#810

Will need to use // $FlowFixMe it appears.

@gajus gajus closed this as completed in 330f6ae Feb 21, 2019
@gajus
Copy link
Owner Author

gajus commented Feb 21, 2019

🎉 This issue has been resolved in version 14.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gajus gajus added the released label Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gajus gajus

Labels
needs-replication
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gajus