Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor views/settings/index.vue to be more component based #155

Open
speza opened this issue Jan 21, 2019 · 0 comments
Open

Refactor views/settings/index.vue to be more component based #155

speza opened this issue Jan 21, 2019 · 0 comments

Comments

@speza
Copy link
Contributor

speza commented Jan 21, 2019

Refactor settings/index.vue to be more component based

Currently the settings view is all in a single Vue file - views/settings/index.vue.
This is an anti-pattern of using a component based frontend library.

I imagine there are other areas of the client code-base that are the same (this just happened to be the one I was in).

Examples of new components to build out of index.vue:

  • ManageUsers.vue
  • UserTable.vue
  • CreateUserModal.vue

Its much nicer to manage and maintain when like this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants