Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object is not a hash #16

Open
gaearon opened this issue Jan 28, 2015 · 3 comments
Open

Object is not a hash #16

gaearon opened this issue Jan 28, 2015 · 3 comments

Comments

@gaearon
Copy link
Owner

gaearon commented Jan 28, 2015

An object is not a hash.

Currently example fails with usernames such as constructor.

We solve this partially with 487745f but the same needs to be done for RepoStore and UserStore. The easiest way to do this is to create a Bag class and use it instead of mergeIntoBag, isInBag helpers. Inside Bag, we will use prefixes for IDs.

@JakeChampion
Copy link

Could ES6 Maps be used for this instead?

@gaearon
Copy link
Owner Author

gaearon commented May 5, 2015

Yes but they're not really there yet. I don't know much about the polyfill though.

@JakeChampion
Copy link

Kangax's ES6 compat table shows that Babel passes all the Map tests. The polyfill is a part of core-js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants