Workaround cycle analysis freezes #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempt3035
added a commit
to Attempt3035/dep-tree
that referenced
this pull request
Nov 28, 2024
* 'main' of github.com:gabotechs/dep-tree: (47 commits) Update README [skip ci] tag: v0.23.0 feat: Add the ability to ignore nodes from visualization (gabotechs#108) tag: v0.22.5 Improve folder coloring (gabotechs#107) tag: v0.22.4 Workaround cycle analysis freezes (gabotechs#105) tag: v0.22.3 Refactor config and args (gabotechs#104) Update README [skip ci] tag: v0.22.2 Commit index file tag: v0.22.1 Fix folder squash bug tag: v0.22.0 feat: File explorer (gabotechs#103) tag: v0.21.3 Introduce virtual dir modes Fix virtual dir nodes Update README [skip ci] ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be a bug in an upstream library https://github.com/gonum/gonum. The function that freezes is
DirectedCyclesIn, specifically, injohnson.circuit. There's a for loop there with recursion that never ends executing.