fix(uniform): refactor From component

fuf-stack · Apr 15, 2024 · af3d528 · af3d528
1 parent 46f41f5
commit af3d528
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/lint-staged.config.js b/lint-staged.config.js
@@ -1,6 +1,6 @@
 module.exports = {
   // pixels
-  // 'packages/pixels/**/*.{js,ts,tsx}': ['eslint', 'vitest related --run'],
+  'packages/pixels/**/*.{js,ts,tsx}': ['eslint', 'vitest related --run'],
   // uniform
   'packages/uniform/**/*.{js,ts,tsx}': ['eslint', 'vitest related --run'],
   // veto

diff --git a/packages/uniform/src/Form/Form.tsx b/packages/uniform/src/Form/Form.tsx
@@ -61,9 +61,6 @@ const Form = ({
   validation = undefined,
   validationTrigger = 'all',
 }: FormProps) => {
-  const trigger =
-    validationTrigger === 'all-instant' ? 'all' : validationTrigger;
-
   const methods = useForm(
     validation
       ? {
@@ -75,7 +72,9 @@ const Form = ({
             // https://github.com/react-hook-form/resolvers/blob/master/zod/src/zod.ts
             return { values: data || {}, errors: errors || {}, ...rest };
           },
-          mode: trigger, // Validate form (default: all)
+          // set rhf mode
+          // see: https://react-hook-form.com/docs/useform#mode
+          mode: validationTrigger === 'all-instant' ? 'all' : validationTrigger,
         }
       : {
           defaultValues: initialValues,

diff --git a/release-please-config.json b/release-please-config.json
@@ -4,7 +4,7 @@
   "include-component-in-tag": true,
   "packages": {
     "packages/pixels": {},
-    "packages/uniform": { "release-as": "0.0.1" },
+    "packages/uniform": {},
     "packages/veto": {}
   },
   "separate-pull-requests": true

diff --git a/tsconfig.json b/tsconfig.json
@@ -2,6 +2,7 @@
   "references": [
     { "path": "packages/config/storybook-config" },
     { "path": "packages/pixels" },
+    { "path": "packages/uniform" },
     { "path": "packages/veto" }
   ],
   "files": []