-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support big-endian platforms #248
Comments
Hi @dipterix, thanks for your question (and congratulations on your The Solaris errors are due to SystemRequirements: little-endian platform in file |
Uh... I thought fst once supported big-endian system, or Solaris is unsupported all the time? Also do you have any plan to enable big-endian support because neither LZ4 nor ZSTD forces endianess? |
Ha @dipterix, it's possible to use In earlier submissions, CRAN checks were successful because the unit tests did not include reading in default fst files created on a little-endian system... Making thanks for reporting! |
I see. Is it possible to store pre-designed bytes within the meta block that indicates the endianess, for example one or multiple |
Hi @dipterix, you're exactly right :-) In fact, I have already prepared a binary flag in the header of the file that stores the endianess, see this specification. But at the moment, the value is not used to check against the systems endianess, because DESCRIPTION contains SystemRequirements: little-endian platform anyway... |
Hi @MarcusKlik
I recently submitted a package to CRAN, it gets this error during check with Solaris (https://cran.r-project.org/web/checks/check_results_raveio.html)
This error comes from
fst
(https://cran.r-project.org/web/checks/check_results_fst.html)Would you like to investigate?
The text was updated successfully, but these errors were encountered: