fix crashes on kqueue-platforms when built with go-1.14 #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go 1.14 introduces asynchronous preemption, which interrupts running goroutines by sending a SIGURG signal. Some syscalls, like kevent(2), will return EINTR when that happens. grok_exporter was treating EINTR like an error, even though no error code was set. The result was an eventual nil dereference. This patch fixes the bug by restarting kevent on EINTR. Submitted by: @a1exanderpetrov Sponsored by: Axcient Fixes: fstab#90
|
ping. This PR is ready for review. |
|
Thanks for reminding me. Great finding, thanks a lot for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.14 introduces asynchronous preemption, which interrupts running
goroutines by sending a SIGURG signal. Some syscalls, like kevent(2),
will return EINTR when that happens. grok_exporter was treating EINTR
like an error, even though no error code was set. The result was an
eventual nil dereference. This patch fixes the bug by restarting kevent
on EINTR.
Submitted by: @a1exanderpetrov
Sponsored by: Axcient
Fixes: 90