Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Underscores in subsections of configuration docs disappear, plus suggestion for table of contents #2411

Closed
abelbraaksma opened this issue Aug 6, 2022 · 4 comments

Comments

@abelbraaksma
Copy link
Member

abelbraaksma commented Aug 6, 2022

First of all, great work on Fantomas 5!!! I'm going over the changelog of each alpha and beta (didn't find an all-encompassing list somewhere) and I really like what I find!

I found the docs (it seems like they aren't directly linked from the readme.md, I wouldn't mind adding them there), I think these are the ones: https://fsprojects.github.io/fantomas/docs/Configuration.html

If you look at the "Configuration" page, it renders the captions wrongly, because of the _ in the names of the items. I was trying to search for info on certain settings, but that doesn't work because of the rendering:

image

Or this:

image

PS: just an idea, but perhaps we can make an TOC of the editor options on top, that way searching through the page won't be so necessary anymore.

PPS: the same file on Github renders just fine: https://github.com/fsprojects/fantomas/blob/master/docs/docs/Configuration.md

@nojaf
Copy link
Contributor

nojaf commented Aug 6, 2022

Hello,

First of all, great work on Fantomas 5

Thank you 😊.

I found the docs
The documentation is still very much WIP, once we made more progress, the idea is to replace the current README.md with a link to the docs website.

it renders the captions wrongly

Yes, this is a bug in fsdocs (see fsprojects/FSharp.Formatting#389).
Feel free to take a stab at that one 😅.

TOC of the editor

That is a good idea, I would accept a PR for that.

@abelbraaksma abelbraaksma changed the title The docs, esp the configuration file, are rendered oddly, leading to wrong config names Underscores in subsections of configuration docs disappear, plus suggestion for table of contents Aug 8, 2022
@abelbraaksma
Copy link
Member Author

abelbraaksma commented Aug 8, 2022

That is a good idea, I would accept a PR for that.

Done 😃. See #2414.

Yes, this is a bug in fsdocs (see fsprojects/FSharp.Formatting#389).

I tried to circumvent the bug in that PR. Not 100% it works as I don't know how your CI renders that page. If it doesn't know how to deal with escaped characters like \_, this isn't gonna look pretty.

@nojaf
Copy link
Contributor

nojaf commented Aug 8, 2022

@nojaf
Copy link
Contributor

nojaf commented Aug 18, 2022

Due to the upstream fix of FSharp.Formatting, this is no longer a problem.

@nojaf nojaf closed this as completed Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants