-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new XAML option page #10
base: master
Are you sure you want to change the base?
Conversation
src/FantomasOptionsPage2.xaml
Outdated
@@ -0,0 +1,40 @@ | |||
<UserControl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR!
It looks like it's off to a good start.
I wonder if we should prototype it as a separate WPF project.
Running it each time in VS is very slow.
@deviousasti Let me know how you want to split up the work. Also the |
Pushed the highlighter. |
I will try to work on this by the end of the week. I am just wondering whether you prefer to go in the direction of hardcoding each property on the VM (similar to what is currently done) or if you would rather have some kind of a collection of some type (name, description?, values and maybe a map of value -> example)? |
Based on your suggestions, I made a sort of hybrid of all the above editors. Nice things:
To proceed, we'd need to figure out:
...and anything else you can think of. |
Were you able to try this out? Any opinions? |
# Conflicts: # fantomas # src/FantomasHandler.cs # src/FantomasOptionsPage.cs # src/FantomasVs.sln
@deviousasti Hey sorry for the BIG delay in my contribution... I got really busy at work and kind of without motivation at home for some time. I have just tried to merge master and play with the UI, I think it looks really interesting and promising. I would probably stick to a more common style for some controls (e.g. disabled/enabled) but that's a personal preference.
I think it would be worth sharing them with/from the fantomas repository to have something in-sync. I don't know if there is any format used/defined. If nothing exists, we could create some locally but it feels like duplicating work from the original repo so I would probably ask there if they would be ok to do something common.
Probably depends upon the answer of the previous question. |
It's important to take care of yourself, and how things are right now, nobody would blame you even if you didn't come back to finish this. So, first of all, a BIG thank you for thinking about finishing this!🙇 After merging with master, has the extension worked for you?
|
Fix #9