Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to use Paket with MonoAndroid TargetFrameworkVersion v12.0? #4112

Closed
Dolfik1 opened this issue Jan 19, 2022 · 1 comment · Fixed by #4113
Closed

How to use Paket with MonoAndroid TargetFrameworkVersion v12.0? #4112

Dolfik1 opened this issue Jan 19, 2022 · 1 comment · Fixed by #4113

Comments

@Dolfik1
Copy link
Contributor

Dolfik1 commented Jan 19, 2022

Description

I changed the TargetFrameworkVersion to 12.0 in my project but the package still generates the wrong condition:

<Choose>
    <When Condition="$(TargetFrameworkIdentifier) == 'MonoAndroid' And $(TargetFrameworkVersion) == 'v10.0'">
      <PropertyGroup>
        <__paket__Xamarin_Android_Support_VersionedParcelable_targets>monoandroid90\Xamarin.Android.Support.VersionedParcelable</__paket__Xamarin_Android_Support_VersionedParcelable_targets>
      </PropertyGroup>
    </When>
  </Choose>

Repro steps

  1. Create blank MonoAndroid app and add any dependency.

  2. Set TargetFrameworkVersion to v12.0

  3. Run dotnet paket install

Expected behavior

<Choose>
    <When Condition="$(TargetFrameworkIdentifier) == 'MonoAndroid' And $(TargetFrameworkVersion) == 'v12.0'">
      <PropertyGroup>
        <__paket__Xamarin_Android_Support_VersionedParcelable_targets>monoandroid90\Xamarin.Android.Support.VersionedParcelable</__paket__Xamarin_Android_Support_VersionedParcelable_targets>
      </PropertyGroup>
    </When>
  </Choose>

Actual behavior

<Choose>
    <When Condition="$(TargetFrameworkIdentifier) == 'MonoAndroid' And $(TargetFrameworkVersion) == 'v10.0'">
      <PropertyGroup>
        <__paket__Xamarin_Android_Support_VersionedParcelable_targets>monoandroid90\Xamarin.Android.Support.VersionedParcelable</__paket__Xamarin_Android_Support_VersionedParcelable_targets>
      </PropertyGroup>
    </When>
  </Choose>

Known workarounds

None

@Dolfik1
Copy link
Contributor Author

Dolfik1 commented Jan 20, 2022

@forki should we add monoandroid11.0/monoandroid12.0 support to Paket?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant