From 6fd2b309a4d2c0db41e738e3c20d459e4f2396dd Mon Sep 17 00:00:00 2001 From: Kevin Schneider Date: Mon, 18 Jan 2021 11:29:49 +0100 Subject: [PATCH 1/2] Update Dockerfile and NuGet.config for binder --- docs/Dockerfile | 20 ++++++++++---------- docs/NuGet.config | 6 ++---- 2 files changed, 12 insertions(+), 14 deletions(-) diff --git a/docs/Dockerfile b/docs/Dockerfile index 4357da9f3..72f1eba6f 100644 --- a/docs/Dockerfile +++ b/docs/Dockerfile @@ -2,7 +2,7 @@ FROM jupyter/base-notebook:latest # Install .NET CLI dependencies -ARG NB_USER=jovyan +ARG NB_USER=fsdocs-user ARG NB_UID=1000 ENV USER ${NB_USER} ENV NB_UID ${NB_UID} @@ -22,7 +22,7 @@ ENV \ # Skip extraction of XML docs - generally not useful within an image/container - helps performance NUGET_XMLDOC_MODE=skip \ # Opt out of telemetry until after we install jupyter when building the image, this prevents caching of machine id - DOTNET_TRY_CLI_TELEMETRY_OPTOUT=true + DOTNET_INTERACTIVE_CLI_TELEMETRY_OPTOUT=true # Install .NET CLI dependencies RUN apt-get update \ @@ -39,11 +39,11 @@ RUN apt-get update \ # Install .NET Core SDK # When updating the SDK version, the sha512 value a few lines down must also be updated. -ENV DOTNET_SDK_VERSION 3.1.301 +ENV DOTNET_SDK_VERSION 5.0.101 -RUN dotnet_sdk_version=3.1.301 \ +RUN dotnet_sdk_version=5.0.101 \ && curl -SL --output dotnet.tar.gz https://dotnetcli.azureedge.net/dotnet/Sdk/$dotnet_sdk_version/dotnet-sdk-$dotnet_sdk_version-linux-x64.tar.gz \ - && dotnet_sha512='dd39931df438b8c1561f9a3bdb50f72372e29e5706d3fb4c490692f04a3d55f5acc0b46b8049bc7ea34dedba63c71b4c64c57032740cbea81eef1dce41929b4e' \ + && dotnet_sha512='398d88099d765b8f5b920a3a2607c2d2d8a946786c1a3e51e73af1e663f0ee770b2b624a630b1bec1ceed43628ea8bc97963ba6c870d42bec064bde1cd1c9edb' \ && echo "$dotnet_sha512 dotnet.tar.gz" | sha512sum -c - \ && mkdir -p /usr/share/dotnet \ && tar -ozxf dotnet.tar.gz -C /usr/share/dotnet \ @@ -52,7 +52,7 @@ RUN dotnet_sdk_version=3.1.301 \ # Trigger first run experience by running arbitrary cmd && dotnet help -# Copy notebooks (and all docs, but who case) across +# Copy notebooks COPY ./ ${HOME}/notebooks/ @@ -66,8 +66,8 @@ USER ${USER} #Install nteract RUN pip install nteract_on_jupyter -# Install lastest build from master branch of Microsoft.DotNet.Interactive from myget -RUN dotnet tool install -g Microsoft.dotnet-interactive --add-source "https://dotnet.myget.org/F/dotnet-try/api/v3/index.json" +# Install lastest build from master branch of Microsoft.DotNet.Interactive +RUN dotnet tool install -g Microsoft.dotnet-interactive --add-source "https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-tools/nuget/v3/index.json" #latest stable from nuget.org #RUN dotnet tool install -g Microsoft.dotnet-interactive --add-source "https://api.nuget.org/v3/index.json" @@ -79,7 +79,7 @@ RUN echo "$PATH" RUN dotnet interactive jupyter install # Enable telemetry once we install jupyter for the image -ENV DOTNET_TRY_CLI_TELEMETRY_OPTOUT=false +ENV DOTNET_INTERACTIVE_CLI_TELEMETRY_OPTOUT=false # Set root to notebooks -WORKDIR ${HOME}/notebooks/ +WORKDIR ${HOME}/notebooks/ \ No newline at end of file diff --git a/docs/NuGet.config b/docs/NuGet.config index c5b00b52a..cf1ace51a 100644 --- a/docs/NuGet.config +++ b/docs/NuGet.config @@ -8,9 +8,7 @@ - - - + - + \ No newline at end of file From 5b921e17277e9b4ba7416832d0f774c193d1bc1f Mon Sep 17 00:00:00 2001 From: Kevin Schneider Date: Mon, 18 Jan 2021 11:30:17 +0100 Subject: [PATCH 2/2] Decrease verbosity of the assembly helper --- src/FSharp.Formatting.Common/YaafFSharpScripting.fs | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/FSharp.Formatting.Common/YaafFSharpScripting.fs b/src/FSharp.Formatting.Common/YaafFSharpScripting.fs index 1613b9a16..f33470499 100644 --- a/src/FSharp.Formatting.Common/YaafFSharpScripting.fs +++ b/src/FSharp.Formatting.Common/YaafFSharpScripting.fs @@ -145,8 +145,6 @@ module internal CompilerServiceExtensions = yield fileName1 |] - for arg in args do - printfn "arg: %s" arg projFileName, args let getProjectReferences frameworkVersion otherFlags libDirs dllFiles =