You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
while working on "my PR" I needed to add a new pipeline to simplify testing the output of the API Docs generations using a test project.
While doing so I saw that some variables are not used in the build.fsx:
// Information about the project to be used at NuGet and in AssemblyInfo filesletproject="FSharp.Formatting"letsummary="A package of libraries for building great F# documentation, samples and blogs"letlicense="Apache 2.0 License"
Are you ok if I send a PR to delete dead code?
For my pipeline addition, I need to work with "complex path" and lengthy CLI. Would you be ok if I was to introduce the 2 packages below?
I want to push back on that a little. Once we merge, it's on us to maintain, so we need to be sure it's necessary. Is this really something that needs to be part of the repository? Without more context, it feels like this might be more about your preferred workflow than a true necessity.
Are you ok if I send a PR to delete dead code?
Sure, go ahead.
Would you be ok if I was to introduce the 2 packages below?
My initial reaction is no. Adding new dependencies can lead to issues down the line, especially with dotnet. Things tend to break over time, so we should be cautious about introducing anything new unless it's absolutely necessary.
My initial reaction is no. Adding new dependencies can lead to issues down the line, especially with dotnet. Things tend to break over time, so we should be cautious about introducing anything new unless it's absolutely necessary.
As you wish, I think that working with string interpolation for CLI is harder to maintain because you need to escape arguments and things like that.
I want to push back on that a little. Once we merge, it's on us to maintain, so we need to be sure it's necessary. Is this really something that needs to be part of the repository? Without more context, it feels like this might be more about your preferred workflow than a true necessity.
The needs will be explained in the signature-like PR because it is related to that enhancement.
Hello,
while working on "my PR" I needed to add a new
pipeline
to simplify testing the output of the API Docs generations using a test project.While doing so I saw that some variables are not used in the
build.fsx
:Are you ok if I send a PR to delete dead code?
For my pipeline addition, I need to work with "complex path" and lengthy CLI. Would you be ok if I was to introduce the 2 packages below?
I used these projects extensively for a while now and it simplified a lot my build script experience while making maintenance easier.
I can create a separate PR to showcase how it would look like.
The text was updated successfully, but these errors were encountered: