Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax FSharp.Compiler.Service dependency version #934

Open
Thorium opened this issue Aug 6, 2024 · 1 comment · Fixed by #935
Open

Relax FSharp.Compiler.Service dependency version #934

Thorium opened this issue Aug 6, 2024 · 1 comment · Fixed by #935

Comments

@Thorium
Copy link
Member

Thorium commented Aug 6, 2024

Current Nuget package states dependency:
FSharp.Compiler.Service = 43.8.100

(which is corrseponding FSharp.Core 8.0.100)

But there is already new FSharp.Compiler.Service 43.8.301
(...and corresponding FSharp.Core 8.0.301)

This project should not state exact F# compiler service dependency, but rather more relaxed >=.
Or if you want to keep releasing new Nuget-packages, then at least < 43.9.

Currently if I just run paket install with F# 8.0.301 then it reverts FSharp.Formatting to version 20 -> 14.0.1 where is more relaxed FSharp.Compiler.Service (>= 40.0.0)

@nojaf
Copy link
Collaborator

nojaf commented Aug 6, 2024

This project should not state exact F# compiler service dependency, but rather more relaxed

I understand the idea of having a more relaxed dependency on the F# compiler service for this project. However, I have some concerns. FCS versions don't always follow semver and can sometimes be incompatible with each other. For example, there are no release notes for 8.0.301 here: https://github.com/dotnet/fsharp/tree/main/docs/release-notes/.FSharp.Compiler.Service. So, we can't be sure if it's binary compatible with 8.0.300.

Relaxing the dependency might lead to issues if the next FCS release isn't stable for our project. It feels a bit risky, and I don't want us to run into unexpected runtime problems.

What do you think, @baronfel?

@nojaf nojaf closed this as completed in #935 Aug 6, 2024
@nojaf nojaf reopened this Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants