FSharp.Formatting package contains MSBuild assemblies

[rainersigwald]

While helping investigate test failures in ionide/FsAutoComplete#825, I noticed that FSharp.Formatting contains several MSBuild assemblies:

• Microsoft.Build.Framework.dll
• Microsoft.Build.Tasks.Core.dll
• Microsoft.Build.Utilities.Core.dll
• Microsoft.NET.StringTools.dll

That caused some surprising behavior, since MSBuild assemblies need to be located from Visual Studio or a .NET SDK rather than redistributed with an application, because of their entanglement with targets and tasks that are part of the SDK. MSBuildLocator docs have some details.

Can those files be elided from the package?

[baronfel]

They seem to be packaged as content in the project file here, which seems odd to me. Since this project is the library package, I'm not sure it should have msbuild refs directly, instead relying on its package dependencies to bring those in if required.

The msbuild refs might be required by the dotnet tool via the proj-info reference, but that's an entirely different scenario.

In any case, for that PR we'll likely drop the dependency, as it was powering one rarely-used feature, until this is resolved.

[nhirschey]

Closed with #715