Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu is not scrollable on mobile #672

Closed
nhirschey opened this issue Apr 28, 2021 · 5 comments
Closed

Menu is not scrollable on mobile #672

nhirschey opened this issue Apr 28, 2021 · 5 comments

Comments

@nhirschey
Copy link
Collaborator

Following up on comment here fsprojects/FSharp.Data#1370 (comment)

Summary: if you’re on a mobile browser then clicking the sidebar/hamburger on the current template fills the browser window with the sidebar, and that sidebar menu that pops out is not scrollable. So it’s impossible (at least on iOS) to scroll to and click on links at the bottom of the side bar. You’re restricted to the first few items on the sidebar. In the screenshot in the above linked FSharp.Data comment, I can’t access anything below XML Provider.

@dsyme
Copy link
Contributor

dsyme commented May 17, 2021

Thanks for the fix!

@dsyme dsyme closed this as completed May 17, 2021
@dsyme dsyme reopened this Jul 22, 2021
@dsyme
Copy link
Contributor

dsyme commented Jul 22, 2021

@nhirschey Scrollable navbar looks a bit off for desktop, see

https://fsprojects.github.io/FSharp.Formatting/

image

Reopening this to sort it out

@nhirschey
Copy link
Collaborator Author

Ok, I will see if I can find a way to expand it so that it fills the vertical real estate on desktop. In your screenshot the scrollbar isn’t needed.

@nhirschey
Copy link
Collaborator Author

Pull request #689 is the most minimal change to the template that

  1. Has no navbar scrollbar on desktop when there is sufficient vertical space to display all navbar items.
  2. Makes the navbar usable on mobile browsers (by adding a scrollbar, see update docs FSharp.Data#1370 (comment) for a description of the problem).

That said, the current navbar in the FSharp.Formatting template could probably be simplified. I will experiment as I have time.

@dsyme
Copy link
Contributor

dsyme commented Jul 23, 2021

Thank you! that's great

@dsyme dsyme closed this as completed Jul 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants