Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The command tool's cache is serialized with the BinaryFormatter #614

Closed
teo-tsirpanis opened this issue Oct 14, 2020 · 0 comments · Fixed by #615
Closed

The command tool's cache is serialized with the BinaryFormatter #614

teo-tsirpanis opened this issue Oct 14, 2020 · 0 comments · Fixed by #615

Comments

@teo-tsirpanis
Copy link
Contributor

As seen in BuildCommand.fs, the project cracker cache the command tool stores in .fsdocs/cache is serialized using the insecure and deprecated BinaryFormatter class.

To close this potential security hole, the command tool should use a safe serializer for its cache, such as the data contract serializer. Such change would break the existing cache files but the impact from this change is minimal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant