Markdown: Underscores in the middle of a word translate as emphasis

[allykzam]

I can't find a part of the CommonMark spec that explicitly states it rather than just being implied by the left/right flanking delimiter rules, but emphasis with the underscore like some_words_here should be translated as some_words_here, but come out of FSharp.Markdown as some<em>words</em>here. Spec has a few examples of this; makes snake-case value names output wrong 😬

Edit: Forgot links

[matthid]

The tests for the common-mark spec are already implemented so if you have some time feel free to enable them and send a PR. Would be really appreciated as I only had time to implement two sections, namely 'Fenced code blocks' and 'Indented code blocks'.

Just add 'Emphasis and strong emphasis' to here and fix the failing unit tests :)

[tpetricek]

This is one place where CommonMark makes a lot more sense than original Markdown :) would love to see this behaviour improved!

[allykzam]

I can't actually get the tests to run on my system. I'll take another look later, but so far the version of Fake in paket.lock thinks it needs to use mono to run MSBuild on Windows 10, and that the given NUnit expects me to have MSBuild 12 installed (I only have 14, as I've never installed VS 2013 on this system).

[matthid]

Feel free to update everything with paket update. If it doesn't help we might need to file an issue in FAKE? For the NUnit problem I'm not sure what's going on.

[allykzam]

It did look like the latest Fake was working correctly, but that was the last thing I got finished. I'm closing in on a 1.0 release on a project at work, so it might be a week or two before I have time to really dig into this.

[tpetricek]

This sounds like an instance of fsharp/fsharp-compiler-docs#337

@dsyme @rneatherway Is this in the 1.4.2.* branch of F.C.S. releases too?

[rneatherway]

The new project cracker is only in 2.X I'm afraid.

[tpetricek]

@rneatherway Thanks!

@dungpa @vasily-kirichenko Is the latest version of FSharpVSPowerTools.Core going to work with FCS 2.x? If so, we should be able to update the reference in F# Formatting...

Although I guess that would only work if FAKE also did that (cc @forki)...

[vasily-kirichenko]

I didn't know there is 2.x version of FCS. We could try to update to it and run the tests.

Done fsprojects-archive/zzarchive-VisualFSharpPowerTools#1317

[tpetricek]

I'm closing this in favor of #389, which does not have unrelated discussion :)