Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make F# Formatting compatible with CommonMark #191

Open
kimsk opened this issue Sep 5, 2014 · 7 comments
Open

Make F# Formatting compatible with CommonMark #191

kimsk opened this issue Sep 5, 2014 · 7 comments

Comments

@kimsk
Copy link
Contributor

kimsk commented Sep 5, 2014

There is an attempt to standardized Markdown at CommonMark which I think it's a good idea.

I tried FSharp.Formatting with the sample that Jeff Atwood gives, and the output html is below.

<h1>Hello there</h1>

<p>This is a paragraph.</p>

<ul>
<li>one</li>
<li>two</li>
<li>three</li>
<li><p>four</p></li>
<li>pirate</li>
<li>ninja</li>
<li>zombie</li>
</ul>

I just want to throw the idea around. :-)

@tpetricek
Copy link
Member

Looks like F# Formatting is definitely not doing a good job here :-)

Any pull requests that make our implementation closer to the CommonMark format (or whatever it is called today) would be more than welcome.

  • I know for sure that the parsing of lists is a mess and needs to be changed!
  • The other area is that common markdown describes how to deal with multiple *nested **emphasis** commands* (by taking the space into account), which would be nice addition too.
  • It would also be nice to see if there are any tests in CommonMark that we could adopt.

@tpetricek tpetricek changed the title Make Html output from FSharp.Formatting compatible with standard markdown Make F# Formatting compatible with CommonMark Sep 7, 2014
@matthid
Copy link
Member

matthid commented Dec 29, 2015

This is now in progress since #343, feel free to enable one of the sections here, fix all the enabled tests and send a PR ;)

I hope I find some time to add some more documentation here: http://tpetricek.github.io/FSharp.Formatting/development.html

@theprash
Copy link
Contributor

I've made some progress on this: #404

@dsyme
Copy link
Contributor

dsyme commented Apr 13, 2019

Closing as progress was made in #343 and #404, there are no disabled tests remaining in the linked test?

@dsyme dsyme closed this as completed Apr 13, 2019
@realvictorprm
Copy link

@dsyme you're staying up too long :D

@matthid
Copy link
Member

matthid commented Apr 13, 2019

We have ported all tests from the spec and the numbers are:

Total tests: 707. Passed: 157. Failed: 0. Skipped: 550

So I'd say we aren't anywhere near the spec ;)

@matthid matthid reopened this Apr 13, 2019
@dsyme
Copy link
Contributor

dsyme commented Apr 13, 2019

Ah cool, good to have the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants