-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VS2015 FSLab journal template dll reference error. #98
Comments
Slightly different error building from the VS template (VS2015). Smells a lot like this issue, which is closed but maybe not fully resolved: fsprojects/FSharp.Formatting#337?
|
Couple comments: |
Does it work if you use the latest version of F# formatting? (Download the template from https://github.com/fslaborg/FsLab.Templates/archive/journal.zip and run |
No, it does not work for me either... let me investigate... |
I updated everything to the latest version (including new F# Formatting and new FAKE) and it seems to be happy again. |
Thanks Tomas!
If I get a chance this evening I'll poke a little further. |
Hmm... I've seen this error and I'm not quite sure when it happens. Just to make sure, are you saying that:
That would be quite curious, because the download link in the first one points to the contents of the repository! Perhaps this behaves in some non-deterministic way... Can you see Does deleting the line fix the issue (or does it cause some other issues)? |
Hi Tomas, |
Yes! Deleting the line fixes the issue. |
This is really odd. I just updated the template in VS gallery and it should now be exactly the same as the one on the web (the Can you check if this still reproduces with the most recent version? (To make sure, it is probably best to uninstall the old one and do all experiments in a folder that you have not used before in case something somewhere gets cached!) |
Also, thanks for pointing out that the template in VS Gallery was different :-) I wanted to update it for ages! |
Hi Tomas, However that archive is not the same as the one we get from the gallery or the one that's built from the FSLab repo. Specifically, build.cmd is missing in the gallery/repo builds, so while the template can be installed, launching runner fails to execute the build.cmd subprocess. I'm a bit puzzled as to how build.cmd stopped being included in the zip archive- I can't find any evidence that it was ever packed in the first place. Does a different process generate the archive at the GitHub url above? |
I updated the template again and it should work now. The idea is that the VS template only comes with minimal number of files (so that we do not have to change it often) and when you run it in VS, it actually copies the build scripts from a NuGet package - see the code here. I messed things up in the last version, so it didn't do it. Now it should work again - so when you use the template, you'll get all the right build scripts after you run it once in VS (while the standalone download has everything included, because we expect more command line users getting that :-)). I changed the project so that it now fetches everything from the FsLab templates repo, so that's the place where all changes can be made. |
Looks like I finally figured this out. This was the fix: fsprojects/FSharp.Formatting@5f1e1aa |
I had a similar problem (nondeterministic?) with my presentation in FsReveal.
|
This issue seems to be distinct from Issue #82.
build run
from the VS2015 command line fails to successfully reference FSharp.CodeFormat:Here's the paket output from a clean unzip:
The text was updated successfully, but these errors were encountered: