Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG FsSpreadsheet.Exceljs] ClosedXml files cannot be read from exceljs #58

Open
Freymaurer opened this issue Aug 2, 2023 · 4 comments
Labels
Type: Bug Something is not working, and it is confirmed by maintainers to be a bug.

Comments

@Freymaurer
Copy link
Collaborator

Freymaurer commented Aug 2, 2023

Test is commented out in tests/JS/Exceljs.

Opening and saving the file will make the test pass. THIS is not the behaviour we want, therefore never save the file

image

@Freymaurer Freymaurer added the bug Something isn't working label Aug 2, 2023
@omaus
Copy link
Collaborator

omaus commented Sep 30, 2023

Not directly about the issue but about the wording: ClosedXML is a library that uses OpenXML, as we do. But we do not have anything to do with ClosedXML, so it'd be better to get rid of their name here before any misunderstandings happen. 😅
@Freymaurer what you meant is probably OpenXML

@Freymaurer
Copy link
Collaborator Author

No it is on purpose. We should thrive to suppot read in of files produced by openxml/closedxml/exceljs

@Freymaurer
Copy link
Collaborator Author

In tests/JS/Exceljs:

// TypeError: Cannot read properties of undefined (reading 'company')
it('ClosedXml.Table', async () => {
    const path = "tests/JS/TestFiles/ClosedXml.Table.xlsx";
    const fswb = await Xlsx.fromXlsxFile(path)
    let worksheets = fswb.GetWorksheets()
    equal(worksheets.length, 1)
});

@Freymaurer
Copy link
Collaborator Author

image

@kMutagene kMutagene added Type: Bug Something is not working, and it is confirmed by maintainers to be a bug. and removed bug Something isn't working labels Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something is not working, and it is confirmed by maintainers to be a bug.
Projects
None yet
Development

No branches or pull requests

3 participants