Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken links on docs homepage #970

Closed
0101 opened this issue Aug 25, 2022 · 4 comments
Closed

Broken links on docs homepage #970

0101 opened this issue Aug 25, 2022 · 4 comments

Comments

@0101
Copy link

0101 commented Aug 25, 2022

Links on docs homepage under Documentation Topics are broken. They point to e.g.

  • https://fsharp.github.io/fsharp-compiler-docs/overview.md
    instead of just
  • https://fsharp.github.io/fsharp-compiler-docs/overview

It should probably be fixed in https://github.com/fsprojects/FSharp.Formatting but we could also just remove the .md suffixes from the docs source. Which will probably work fine everywhere.

@baronfel
Copy link
Collaborator

I wonder if this has already been fixed in the FSharp.Formatting tool? I think we're quite behind in this repository at the moment.

@nojaf
Copy link
Collaborator

nojaf commented Aug 25, 2022

Nope, we put in .html in our Markdown files in the Fantomas repo to overcome this.
It still is a problem in fsdocs. Not sure if there already is an issue created for that.

@dsyme
Copy link
Contributor

dsyme commented Aug 30, 2022

Should be fixed by fsprojects/FSharp.Formatting#767

Problem seems to have been related to using relative input paths (which is normal) - the testing for link translation in FSharp.Formatting was only testing absolute input paths --input <absolute-path>

@nojaf
Copy link
Collaborator

nojaf commented Sep 6, 2023

This appears to be fixed.

@nojaf nojaf closed this as completed Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants