Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ng-required option with ng-model is not working correctly #215

Open
tajinderjit13 opened this issue Sep 5, 2019 · 2 comments
Open

ng-required option with ng-model is not working correctly #215

tajinderjit13 opened this issue Sep 5, 2019 · 2 comments

Comments

@tajinderjit13
Copy link

When using ng-required or required attribute on textarea the modelValue is set to undefined. This is happening mainly because the $isEmpty function is always returning true.
https://github.com/froala/angular-froala/blob/master/src/angular-froala.js#L97
@tajinderjit13
Copy link
Author

tajinderjit13 commented Sep 5, 2019 •
edited
Loading

Pull Request for the above fix #216
@navneetnagpal @stefanneculai

@robinwassen
Copy link

@navneetnagpal

Seems like you should merge this since it has gone 3 months and the PR is a straight forward oneliner that fixes one of the many issues with this library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@robinwassen @tajinderjit13