-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
angular-froala does not show content before click when initOnClick set to true #164
Labels
Comments
agabhane
changed the title
angular-froala does not show content when initOnClick set to true
angular-froala does not show content before click when initOnClick set to true
Jan 4, 2018
We're also affected by this issue and it's preventing us from using Froala in production. Just to make sure that this was an issue in angular-froala we created a jsfiddle using Froala without angular, where the issue is not reproducible: https://jsfiddle.net/a9h6kpy0/ |
Fix seems to work. Thanks! |
It should be fixed on the current master. Could you please check?
… On 3 Mar 2018, at 15:17, Frank Wennerdahl ***@***.***> wrote:
@stefanneculai: The issue is that the 'froalaEditor.initialized' isn't fired when using initOnClick: true until the editor has been clicked. 01bcc7d doesn't fix this as flushNgModel() still won't be executed until this event has fired.
Also, when it does ctrl.initializedwill be set to true anyway so the added line won't be executed.
Please re-consider #171 as it has taken these things into consideration.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Yes, I noticed the other changes in e124ecf after I posted the message. Tested and it's working 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I am using
angular-froala
with angular 1.5.x and came across the below issue.I am initializing froala with
initOnClick
astrue
.The problem is, it is not showing content before clicking.
If my variable given to
ng-model
is not empty then it should display the content and not placeholder.Please find attached punker
Example:
If
$scope.myHtml = "<p>Some text</p>";
Actual:
Editor displays default placeholder before clicking.
Expected:
Editor should display "Some text" before clicking
The text was updated successfully, but these errors were encountered: