Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix glossary links and restrict mkdocs-autorefs updates #1043

Merged
merged 3 commits into from
Aug 21, 2024

Conversation

llucax
Copy link
Contributor

@llucax llucax commented Aug 21, 2024

No description provided.

@github-actions github-actions bot added the part:docs Affects the documentation label Aug 21, 2024
@llucax llucax self-assigned this Aug 21, 2024
@llucax llucax marked this pull request as ready for review August 21, 2024 08:04
@llucax llucax requested a review from a team as a code owner August 21, 2024 08:04
@llucax llucax requested review from daniel-zullo-frequenz and removed request for a team August 21, 2024 08:04
@github-actions github-actions bot added the part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) label Aug 21, 2024
@llucax
Copy link
Contributor Author

llucax commented Aug 21, 2024

OK, pinning the dependency for now as it requires some work to fix proper.

@llucax
Copy link
Contributor Author

llucax commented Aug 21, 2024

Copy link
Contributor

@shsms shsms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also a commit message says <= 1.1, but the code change says < 1.1

docs/user-guide/glossary.md Outdated Show resolved Hide resolved
docs/user-guide/glossary.md Outdated Show resolved Hide resolved
llucax added 3 commits August 21, 2024 11:11
The links to the code symbols in the glossary were outdated, using old
names from the logical meter.

Signed-off-by: Leandro Lucarella <[email protected]>
It seems like `mkdocs` now also validates the anchor links in the
documentation, and it was complaining about the broken links in the
glossary. This commit fixes the broken links by changing the anchor
names to lowercase and linking to the code where appropriate.

Signed-off-by: Leandro Lucarella <[email protected]>
Version 1.1.0 will check for links that can resolve to multiple pages,
and we have a few of those, which make the docs build fail.

We will fix these in the future.

Signed-off-by: Leandro Lucarella <[email protected]>
@llucax
Copy link
Contributor Author

llucax commented Aug 21, 2024

Updated to fix all of it.

@llucax llucax requested a review from shsms August 21, 2024 09:12
@llucax llucax changed the title Fix documentation to work with the new mkdocs Fix glossary links and restrict mkdocs-autorefs updates Aug 21, 2024
@llucax llucax added the type:bug Something isn't working label Aug 21, 2024
@llucax llucax added this pull request to the merge queue Aug 21, 2024
Merged via the queue into frequenz-floss:v1.x.x with commit 74b9007 Aug 21, 2024
19 checks passed
@llucax llucax deleted the fix-mkdocs branch August 21, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
part:docs Affects the documentation part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) type:bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

3 participants