Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add warning when installing without running server #825

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

cogk
Copy link
Contributor

@cogk cogk commented Aug 28, 2023

As mentioned in #369 #511 #533 #798 (comment), installing HRMS is not possible if the server is not running, contrary to the other apps. This might (and actually does) lead to confusion, because the error message can be difficult to parse.

Because this issue will probably not be “fixed” soon (see: last 3 comments here #369 (comment)), I believe it's better to show a clear error message.

Detecting whether the server is running is done using the following code taken from frappe/migrate.py:
https://github.com/frappe/frappe/blob/173605fe2c16f8bed2710a6c3e9d6d064cf152de/frappe/migrate.py#L150-L156

Warning

I did not check whether my change breaks things like Frappe Docker, I only checked the manual CLI install.

@cogk cogk requested a review from ruchamahabal as a code owner August 28, 2023 14:56
@ruchamahabal ruchamahabal self-assigned this Aug 30, 2023
@ankush
Copy link
Member

ankush commented Sep 7, 2023

We can add an exception for app installs here:

https://github.com/frappe/frappe/blob/1a563164d7ed85f46c26a685eabd326b101456e6/frappe/utils/background_jobs.py#L122-L126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants