Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON export for flamegraph #8926

Open
Tracked by #8794
HrikB opened this issue Sep 21, 2024 · 2 comments
Open
Tracked by #8794

JSON export for flamegraph #8926

HrikB opened this issue Sep 21, 2024 · 2 comments
Labels
A-tracing Area: tracing C-forge Command: forge Cmd-forge-test Command: forge test T-feature Type: feature T-post-V1 Area: to tackle after V1

Comments

@HrikB
Copy link

HrikB commented Sep 21, 2024

Component

Forge

Describe the feature you would like

Currently, the flamegraph is exported as an svg which can be quite restrictive in exploring the finer details of the gas usage. I think ideally, the flamegraph could be explored with tenderly-style interactivity. I'm pretty agnostic to what program the JSON is to be ingested by.

From some quick research, there's speedscope whose JSON schema look like this.

The original issue suggesting flamegraph support also mentions systrace.

Additional context

No response
@HrikB HrikB added T-feature Type: feature T-needs-triage Type: this issue needs to be labelled labels Sep 21, 2024
@DaniPopes
Copy link
Member

DaniPopes commented Sep 22, 2024 •
edited
Loading

Good candidates for this task are also Google's Perfetto and Firefox's profiler.

@DaniPopes DaniPopes added Cmd-forge-test Command: forge test and removed T-needs-triage Type: this issue needs to be labelled labels Sep 22, 2024
@zerosnacks zerosnacks added C-forge Command: forge A-tracing Area: tracing labels Sep 23, 2024
@mattsse mattsse mentioned this issue Oct 3, 2024
Closed
@zerosnacks zerosnacks mentioned this issue Oct 8, 2024
Open
36 tasks
@zerosnacks
Copy link
Member

Related spec for Google's Perfetto / Firefox Profiler that support the Trace Event Format: https://docs.google.com/document/d/1CvAClvFfyA5R-PhYUmn5OOQtYMH4h6I0nSsKchNAySU/preview?tab=t.0#heading=h.nso4gcezn7n1

@grandizzy grandizzy added the T-post-V1 Area: to tackle after V1 label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-tracing Area: tracing C-forge Command: forge Cmd-forge-test Command: forge test T-feature Type: feature T-post-V1 Area: to tackle after V1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@HrikB @grandizzy @DaniPopes @zerosnacks